minor 1030 emergeCommand bug

[Link]

If you launch "cmd " with emergecommand, it throws an error and crashes.
1030 again
---------------------------
Microsoft Visual C++ Runtime Library
---------------------------




This application has requested the Runtime to terminate it in an unusual way.
Please contact the application's support team for more information.


---------------------------
OK
---------------------------

[ironhead]

Works for me (I use it often).... which version of Windows are you seeing this behaviour on?

[Xaero]

Aye, I just tested with 1030 as well and it worked flawlessly.

[MeToo]

No problem at all with version 1030 (or any other). I use that command several times per day...

Since the error refers to MSVC Runtime, and eD doesn't use MSVC, it must be something else crashing...

[Link]

did you guys type the space after cmd? I did say "cmd " not "cmd"

probably should have mentioned that. It's not correct syntax for sure, but I thought I'd offer it up for error handling / stability. Plus you never know where this might manifest itself as a more serious flaw somewhere down the line

Confirmed crash on both XP SP3 x86 and 7 x64 (SP1)

[Xaero]

Reproduced - emergeCommand crashed too.

[Link]

I don't know how this would work with the new multiple instances, but might I suggest having "emerge.exe activate emergecommand" start emergecommand if it is not running?

[MeToo]

probably should have mentioned that. It's not correct syntax for sure, but I thought I'd offer it up for error handling / stability. Plus you never know where this might manifest itself as a more serious flaw somewhere down the line

Yes you should have mentioned the space
I can confirm the crash although I wouldn't imagine why someone would type a space after cmd

But it does deserve to be fixed just in case

I don't know how this would work with the new multiple instances, but might I suggest having "emerge.exe activate emergecommand" start emergecommand if it is not running?

I have suggested to go back to the previous method where executing emergeCommand a second time activates the command line. This way you can have a single hotkey for emergeCommand. If it's already running pressing it once will activate the command line, if it is not running you just need to press it twice...

Other ideas?

[Link]

I don't know how this would work with the new multiple instances, but might I suggest having "emerge.exe activate emergecommand" start emergecommand if it is not running?

I have suggested to go back to the previous method where executing emergeCommand a second time activates the command line. This way you can have a single hotkey for emergeCommand. If it's already running pressing it once will activate the command line, if it is not running you just need to press it twice...

Other ideas?

Just move the code from "emerge.exe activate emergecommand" to emergecommand.exe. This way, you can retain the new feature of separate instances, by passing the proper arguments to emergecommand.exe...

Or have emerge.exe check if emergecommand is running before trying to activate it.

I can't really come up with a solution that is simple unless I know how multiple instances are handled; is it in a config file somewhere? Does it create emergecommand.1.xml and emergecommand.2.xml and so on? If so, then I assume that when emergecommand is started with no arguments, the first instance is created. Does the second instance get created if executed again? I should play around with this I guess.

[ironhead]

did you guys type the space after cmd? I did say "cmd " not "cmd"

probably should have mentioned that. It's not correct syntax for sure, but I thought I'd offer it up for error handling / stability. Plus you never know where this might manifest itself as a more serious flaw somewhere down the line

Indeed, missed the space the first time I read this. I'll investigate as time permits.

[ironhead]

Fixed in revision 1044, thanks for the report!

[ironhead]

Additionally as of revision 1045, Activate will also start an applet if it's not already running.

Note: this only works for the primary instance of an applet. The changes to allow it to work for additional instances of an applet will come in a future release.